Re: [PATCH v3 3/3] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 (SM-T530)

[Dmitry Baryshkov]

On Sun, 24 Jul 2022 at 20:25, Matti Lehtimäki <matti.lehtimaki@xxxxxxxxx> wrote:
>
> Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T530) wifi tablet
> based on the apq8026 platform.
>
> Currently supported are accelerometer sensor, hall sensor,
> internal storage, physical buttons (power & volume), screen
> (based on simple-framebuffer set up by the bootloader), sdcard,
> touchscreen and USB.
>
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@xxxxxxxxx>
> ---
> Changes in v3:
>   - Fix sdhc_2 bus width
>   - Reorder includes
>
> Changes in v2:
>   - Change codename to matisse-wifi
>   - Remove msm-id, not needed when lk2nd is used
>   - Remove unused labels from reserved memory regions
>   - Rename muic node
> ---
>  arch/arm/boot/dts/Makefile                    |   1 +
>  .../dts/qcom-apq8026-samsung-matisse-wifi.dts | 469 ++++++++++++++++++
>  2 files changed, 470 insertions(+)
>  create mode 100644 arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 5112f493f494..8bac4f4f8656 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1010,6 +1010,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
>         qcom-apq8016-sbc.dtb \
>         qcom-apq8026-asus-sparrow.dtb \
>         qcom-apq8026-lg-lenok.dtb \
> +       qcom-apq8026-samsung-matisse-wifi.dtb \
>         qcom-apq8060-dragonboard.dtb \
>         qcom-apq8064-cm-qs600.dtb \
>         qcom-apq8064-ifc6410.dtb \
> diff --git a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
> new file mode 100644
> index 000000000000..78a119107069
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
> @@ -0,0 +1,469 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2022, Matti Lehtimäki <matti.lehtimaki@xxxxxxxxx>
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/input/input.h>
> +#include "qcom-msm8226.dtsi"
> +#include "qcom-pm8226.dtsi"
> +
> +/delete-node/ &smem_region;

Please move this to the /reserved-memory node. having it there would
help understanding that we are just changing the address.

> +
> +/ {
> +       model = "Samsung Galaxy Tab 4 10.1";
> +       compatible = "samsung,matisse-wifi", "qcom,apq8026";
> +       chassis-type = "tablet";
> +

[skipped]

> +       i2c-muic {
> +               compatible = "i2c-gpio";

Is there any reason for using i2c-gpio rather than blsp_i2c4?
According to the pinctrl-msm8226, gpio14/15 can be mapped to the blsp.

> +               sda-gpios = <&tlmm 14 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
> +               scl-gpios = <&tlmm 15 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
> +
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&muic_i2c_default_state>;
> +
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +
> +               muic: usb-switch@25 {
> +                       compatible = "siliconmitus,sm5502-muic";
> +                       reg = <0x25>;
> +
> +                       interrupt-parent = <&tlmm>;
> +                       interrupts = <67 IRQ_TYPE_EDGE_FALLING>;
> +
> +                       pinctrl-names = "default";
> +                       pinctrl-0 = <&muic_int_default_state>;
> +               };
> +       };

[skipped]


-- 
With best wishes
Dmitry