Re: [External] [PATCH v2 0/4] virtio-crypto: support ECDSA algorithm

From: Daniel P. Berrangé
Date: Thu Jun 30 2022 - 05:48:41 EST


On Thu, Jun 30, 2022 at 03:23:39PM +0800, Lei He wrote:
>
> > On Jun 30, 2022, at 2:59 PM, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Thu, Jun 23, 2022 at 03:05:46PM +0800, Lei He wrote:
> >> From: lei he <helei.sig11@xxxxxxxxxxxxx>
> >>
> >> This patch supports the ECDSA algorithm for virtio-crypto.
> >
> > Why is this necessary?
> >
>
> The main purpose of this patch is to offload ECDSA computations to virtio-crypto dev.
> We can modify the backend of virtio-crypto to allow hardware like Intel QAT cards to
> perform the actual calculations, and user-space applications such as HTTPS server
> can access those backend in a unified way(eg, keyctl_pk_xx syscall).
>
> Related works are also described in following patch series:
> https://lwn.net/ml/linux-crypto/20220525090118.43403-1-helei.sig11@xxxxxxxxxxxxx/

IIUC, this link refers to testing performance of the RSA impl of
virtio-crypto with a vhost-user backend, leveraging an Intel QAT
device on the host. What's the status of that depolyment setup ?
Is code for it published anywhere, and does it have dependancy on
any kernel patches that are not yet posted and/or merged ? Does it
cover both ECDSA and RSA yet, or still only RSA ?

The QEMU backend part of the virtio-crypto support for ECDSA looks fine
to merge, but obviously I'd like some positive sign that the kernel
maintainers are willing to accept the guest driver side.

With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|