RE: [PATCH 02/12] i2c: xiic: Enter standard mode only for > 255 byte read transfers

From: Guntupalli, Manikanta
Date: Thu Jun 30 2022 - 04:06:49 EST




> -----Original Message-----
> From: Krzysztof Adamski <krzysztof.adamski@xxxxxxxxx>
> Sent: Wednesday, June 29, 2022 5:52 PM
> To: Manikanta Guntupalli <manikanta.guntupalli@xxxxxxxxxx>;
> michal.simek@xxxxxxxxxx; Simek, Michal <michal.simek@xxxxxxx>; linux-
> arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; git (AMD-Xilinx) <git@xxxxxxx>
> Cc: Raviteja Narayanam <raviteja.narayanam@xxxxxxxxxx>
> Subject: Re: [PATCH 02/12] i2c: xiic: Enter standard mode only for > 255 byte
> read transfers
>
> CAUTION: This message has originated from an External Source. Please use
> proper judgment and caution when opening attachments, clicking links, or
> responding to this email.
>
>
> Hi,
>
> W dniu 24.06.2022 o 14:05, Manikanta Guntupalli pisze:
> > From: Raviteja Narayanam <raviteja.narayanam@xxxxxxxxxx>
> >
> > To maintain backward compatibility the default transfer mode is
> > dynamic mode. Enter standard mode only when the size of read transfer
> > is > 255 bytes.
> >
> > Signed-off-by: Raviteja Narayanam <raviteja.narayanam@xxxxxxxxxx>
> > Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@xxxxxxxxxx>
>
> [...]
>
> I don't really understand why this patch isn't squashed into previous one. The
> previous patch was only checking the first message which was wrong, this
> one fixes that.

We will fix in V2

Thanks,
Manikanta.