Re: [PATCH V13 09/13] irqchip/loongson-liointc: Add ACPI init support

[Jianmin Lv]

On 2022/6/29 下午9:13, Marc Zyngier wrote:
> On Mon, 27 Jun 2022 12:39:53 +0100,
> Jianmin Lv <lvjianmin@xxxxxxxxxxx> wrote:
> > From: Huacai Chen <chenhuacai@xxxxxxxxxxx>
> >
> > We are preparing to add new Loongson (based on LoongArch, not compatible
> > with old MIPS-based Loongson) support. LoongArch use ACPI other than DT
> > as its boot protocol, so add ACPI init support.
> >
> > LIOINTC stands for "Legacy I/O Interrupts" that described in Section
> > 11.1 of "Loongson 3A5000 Processor Reference Manual". For more
> > information please refer Documentation/loongarch/irq-chip-model.rst.
>
> This is what happens with this series while compiling for MIPS:
>
> drivers/irqchip/irq-loongson-liointc.c: In function ‘liointc_domain_xlate’:
> drivers/irqchip/irq-loongson-liointc.c:170:28: error: ‘GSI_MIN_CPU_IRQ’ undeclared (first use in this function)
>    170 |  *out_hwirq = intspec[0] - GSI_MIN_CPU_IRQ;
>        |                            ^~~~~~~~~~~~~~~
>
> I haven't bothered reviewing more patches, as this is a waste of my
> time.

Sorry for wasting your time, Marc, I just test on my LoongArch machine, 
I'll fix them and test on both of LoongArch and MIPS machine in future.


> 	M.