Re: [PATCH v4 2/5] dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml

From: Christian Marangi
Date: Wed Jun 29 2022 - 18:40:02 EST


On Wed, Jun 29, 2022 at 04:36:59PM -0600, Rob Herring wrote:
> On Wed, 29 Jun 2022 14:14:38 +0200, Christian Marangi wrote:
> > Convert kpss-acc driver Documentation to yaml.
> > The original Documentation was wrong all along. Fix it while we are
> > converting it.
> > The example was wrong as kpss-acc-v2 should only expose the regs but we
> > don't have any driver that expose additional clocks. The kpss-acc driver
> > is only specific to v1. For this exact reason, limit all the additional
> > bindings (clocks, clock-names, clock-output-names and #clock-cells) to
> > v1 and also flag that these bindings should NOT be used for v2.
> >
> > Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> > ---
> > .../bindings/arm/msm/qcom,kpss-acc.txt | 49 ----------
> > .../bindings/arm/msm/qcom,kpss-acc.yaml | 93 +++++++++++++++++++
> > 2 files changed, 93 insertions(+), 49 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt
> > create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/
>
>
> clock-controller@2088000: '#clock-cells' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2088000: 'clock-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2088000: 'clock-output-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2088000: 'clocks' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2098000: '#clock-cells' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2098000: 'clock-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2098000: 'clock-output-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2098000: 'clocks' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@20a8000: '#clock-cells' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20a8000: 'clock-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20a8000: 'clock-output-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20a8000: 'clocks' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20b8000: '#clock-cells' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20b8000: 'clock-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20b8000: 'clock-output-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20b8000: 'clocks' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>

(fixed in the last 2 commit of this series)

--
Ansuel