Re: [PATCH v3 1/2] of: unittest: Switch to use fwnode instead of of_node

From: Bartosz Golaszewski
Date: Wed Jun 29 2022 - 14:50:45 EST


On Wed, Jun 29, 2022 at 1:50 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> GPIO library now accepts fwnode as a firmware node, so
> switch the module to use it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> v3: no changes
> drivers/of/unittest.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> index 7f6bba18c515..5a842dfc27e8 100644
> --- a/drivers/of/unittest.c
> +++ b/drivers/of/unittest.c
> @@ -1602,7 +1602,7 @@ static int unittest_gpio_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, devptr);
>
> - devptr->chip.of_node = pdev->dev.of_node;
> + devptr->chip.fwnode = dev_fwnode(&pdev->dev);
> devptr->chip.label = "of-unittest-gpio";
> devptr->chip.base = -1; /* dynamic allocation */
> devptr->chip.ngpio = 5;
> @@ -1611,7 +1611,7 @@ static int unittest_gpio_probe(struct platform_device *pdev)
> ret = gpiochip_add_data(&devptr->chip, NULL);
>
> unittest(!ret,
> - "gpiochip_add_data() for node @%pOF failed, ret = %d\n", devptr->chip.of_node, ret);
> + "gpiochip_add_data() for node @%pfw failed, ret = %d\n", devptr->chip.fwnode, ret);
>
> if (!ret)
> unittest_gpio_probe_pass_count++;
> --
> 2.35.1
>

Reviewed-by: Bartosz Golaszewski <brgl@xxxxxxxx>