Re: [PATCH v2 2/2] iio: proximity: sx_common: Allow IIO core to take care of firmware node

From: Gwendal Grignou
Date: Wed Jun 29 2022 - 13:07:55 EST


On Wed, Jun 15, 2022 at 4:47 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> IIO core correctly will take care of firmware node if it's not set in
> the driver. Drop ACPI and OF specifics from the driver and allow IIO
> core to handle this.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Reviewed-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx>
> ---
> v2: no changes
> drivers/iio/proximity/sx_common.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iio/proximity/sx_common.c b/drivers/iio/proximity/sx_common.c
> index 9f2e47385198..d70a6b4f0bf8 100644
> --- a/drivers/iio/proximity/sx_common.c
> +++ b/drivers/iio/proximity/sx_common.c
> @@ -5,7 +5,6 @@
> * Common part of most Semtech SAR sensor.
> */
>
> -#include <linux/acpi.h>
> #include <linux/bitops.h>
> #include <linux/byteorder/generic.h>
> #include <linux/delay.h>
> @@ -519,8 +518,6 @@ int sx_common_probe(struct i2c_client *client,
> if (ret)
> return dev_err_probe(dev, ret, "error reading WHOAMI\n");
>
> - ACPI_COMPANION_SET(&indio_dev->dev, ACPI_COMPANION(dev));
> - indio_dev->dev.of_node = client->dev.of_node;
> indio_dev->modes = INDIO_DIRECT_MODE;
>
> indio_dev->channels = data->chip_info->iio_channels;
> --
> 2.35.1
>