Re: [PATCH] ata: pata_cs5535: Fix W=1 warnings

[John Garry]

On 28/06/2022 19:39, Sergey Shtylyov wrote:
> On 6/28/22 1:05 PM, Sergey Shtylyov wrote:
> [...]
> > > > x86_64 allmodconfig build with W=1 gives these warnings:
> > > >
> > > > drivers/ata/pata_cs5535.c: In function ‘cs5535_set_piomode’:
> > > > drivers/ata/pata_cs5535.c:93:11: error: variable ‘dummy’ set but not used [-Werror=unused-but-set-variable]
> > > >    u32 reg, dummy;
> > > >             ^~~~~
> > > > drivers/ata/pata_cs5535.c: In function ‘cs5535_set_dmamode’:
> > > > drivers/ata/pata_cs5535.c:132:11: error: variable ‘dummy’ set but not used [-Werror=unused-but-set-variable]
> > > >    u32 reg, dummy;
> > > >             ^~~~~
> > > > cc1: all warnings being treated as errors
> > > >
> > > > Mark variables 'dummy' as "maybe unused" to satisfy when rdmsr() is
> > > > stubbed, which is the same as what we already do in pata_cs5536.c .
>
>     Wait, what do you mean by "stubbed", the version in <asm/paravirt.h>?

Ah, this mentioning of stubbed is wrong on my part. I was distracted by 
the stub in pata_cs5536.c - that's what my text editor showed me for the 
defintion of rdmsr()

Hi Damien,

I see that you applied this patch. If it has not been pushed can we hand 
edit the commit message or I can send a v2? Or maybe we can live with it...

Thanks,
John

> > > > Signed-off-by: John Garry <john.garry@xxxxxxxxxx>
> >
> > Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
>
> [...]
>
> MBR, Sergey
> .