Re: [PATCH 1/2] Revert "serial: 8250: dw: Move the USR register to pdata"

From: Greg KH
Date: Wed Jun 29 2022 - 02:09:11 EST


On Tue, Jun 28, 2022 at 07:02:31PM -0500, Jeremy Linton wrote:
> pdata is only setup by DT machines, leaving ACPI machines
> with null pdata. Since I don't know the exact mapping of
> ACPI ID's to dw 8250 variations I can't add pdata to them
> without possibly breaking something. As such the simplest
> fix here is probably just to revert this commit.
>
> This reverts commit ffd381445eac2aa624e49bab5a811451e8351008.
> Signed-off-by: Jeremy Linton <jeremy.linton@xxxxxxx>

Didn't checkpatch complain that you need a blank line before your
signed-off-by line?

thanks,

greg k-h