Re: [PATCH 4/4] serial: 8250_dw: Rework ->serial_out() LCR write retry logic

From: Andy Shevchenko
Date: Tue Jun 28 2022 - 16:16:07 EST


On Tue, Jun 28, 2022 at 3:43 PM Ilpo Järvinen
<ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote:
>
> Currently dw8250_verify_write() (was dw8250_check_lcr()) nullifies the
> benefit from differentiated ->serial_out() by having big if tree to
> select correct write type.
>
> Rework the logic such that the LCR write can be retried within the
> relevant ->serial_out() handler:
> 1. Move retries counter on the caller level and pass as pointer to
> dw8250_verify_write()
> 2. Make dw8250_verify_write() return bool
> 3. Retry the write on caller level (if needed)

I'm wondering if it's possible to utilize one of iopoll.h macro here
instead of copying retries and that not-so-obvious IO poll write.

--
With Best Regards,
Andy Shevchenko