Re: [PATCH V4 13/20] rv/reactor: Add the panic reactor

[Steven Rostedt]

On Thu, 16 Jun 2022 10:44:55 +0200
Daniel Bristot de Oliveira <bristot@xxxxxxxxxx> wrote:

> Sample reactor that panics the system when an exception is found. This
> is useful both to capture a vmcore, or to fail-safe a critical system.
> 
> Cc: Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>
> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> Cc: Jonathan Corbet <corbet@xxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Will Deacon <will@xxxxxxxxxx>
> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> Cc: Marco Elver <elver@xxxxxxxxxx>
> Cc: Dmitry Vyukov <dvyukov@xxxxxxxxxx>
> Cc: "Paul E. McKenney" <paulmck@xxxxxxxxxx>
> Cc: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
> Cc: Gabriele Paoloni <gpaoloni@xxxxxxxxxx>
> Cc: Juri Lelli <juri.lelli@xxxxxxxxxx>
> Cc: Clark Williams <williams@xxxxxxxxxx>
> Cc: linux-doc@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-trace-devel@xxxxxxxxxxxxxxx
> Signed-off-by: Daniel Bristot de Oliveira <bristot@xxxxxxxxxx>
> ---
>  kernel/trace/rv/Kconfig         |  8 ++++++
>  kernel/trace/rv/Makefile        |  1 +
>  kernel/trace/rv/reactor_panic.c | 44 +++++++++++++++++++++++++++++++++
>  3 files changed, 53 insertions(+)
>  create mode 100644 kernel/trace/rv/reactor_panic.c
> 
> diff --git a/kernel/trace/rv/Kconfig b/kernel/trace/rv/Kconfig
> index be8e3dab0a52..91a17b13a080 100644
> --- a/kernel/trace/rv/Kconfig
> +++ b/kernel/trace/rv/Kconfig
> @@ -60,4 +60,12 @@ config RV_REACT_PRINTK
>  	  Enables the printk reactor. The printk reactor emmits a printk()
>  	  message if an exception is found.
>  
> +config RV_REACT_PANIC
> +	bool "Panic reactor"
> +	depends on RV_REACTORS
> +	default y if RV_REACTORS

Just put default y if it already depends on RV_REACTORS.

-- Steve

> +	help
> +	  Enables the panic reactor. The panic reactor emmits a printk()
> +	  message if an exception is found and panic()s the system.
> +
>  endif # RV
> diff --git a/kernel/trace/rv/Makefile b/kernel/trace/rv/Makefile