[PATCH -next] net: pcs-rzn1-miic: fix return value check in miic_probe()

From: Yang Yingliang
Date: Tue Jun 28 2022 - 07:59:02 EST


If devm_platform_ioremap_resource() fails, it never return
NULL pointer, replace NULL test with IS_ERR().

Fixes: 7dc54d3b8d91 ("net: pcs: add Renesas MII converter driver")
Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
---
drivers/net/pcs/pcs-rzn1-miic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c
index 8f5e910f443d..d896961e48cc 100644
--- a/drivers/net/pcs/pcs-rzn1-miic.c
+++ b/drivers/net/pcs/pcs-rzn1-miic.c
@@ -461,8 +461,8 @@ static int miic_probe(struct platform_device *pdev)
spin_lock_init(&miic->lock);
miic->dev = dev;
miic->base = devm_platform_ioremap_resource(pdev, 0);
- if (!miic->base)
- return -EINVAL;
+ if (IS_ERR(miic->base))
+ return PTR_ERR(miic->base);

ret = devm_pm_runtime_enable(dev);
if (ret < 0)
--
2.25.1