Re: [PATCH 02/14] dt-bindings: display: panel: allow ilitek,ili9341 in isolation

From: Conor.Dooley
Date: Tue Jun 28 2022 - 02:26:29 EST


On 28/06/2022 00:17, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Sat, Jun 18, 2022 at 01:30:24PM +0100, Conor Dooley wrote:
>> From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>>
>> The dt-binding for the ilitek,ili9341 does not allow it to be used as a
>> compatible in isolation. This generates a warning for the Canaan kd233
>> devicetree:
>> arch/riscv/boot/dts/canaan/canaan_kd233.dtb: panel@0: compatible:0: 'ilitek,ili9341' is not one of ['st,sf-tc240t-9370-t']
>> From schema: Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml
>> arch/riscv/boot/dts/canaan/canaan_kd233.dtb: panel@0: compatible: ['ilitek,ili9341'] is too short
>> From schema: Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml
>> Allow ilitek,ili9341 to be selected in isolation.
>
> Just because you get a warning doesn't mean it is right. ili9341 is a
> panel driver IC, not a complete panel. It needs a more specific
> compatible.

pff, makes sense. I'll conjure one up.
Thanks,
Conor.