Re: [PATCH -next] scsi: ufs: ufs-mediatek: Fix build error and type unmatch

From: Martin K. Petersen
Date: Mon Jun 27 2022 - 23:26:17 EST


On Sun, 19 Jun 2022 19:54:32 +0800, Ren Zhijie wrote:

> If CONFIG_PM_SLEEP is not set.
>
> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-, will be failed, like this:
>
> drivers/ufs/host/ufs-mediatek.c: In function ‘ufs_mtk_vreg_fix_vcc’:
> drivers/ufs/host/ufs-mediatek.c:688:46: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 4 has type ‘long unsigned int’ [-Wformat=]
> snprintf(vcc_name, MAX_VCC_NAME, "vcc-opt%u", res.a1);
> ~^ ~~~~~~
> %lu
> drivers/ufs/host/ufs-mediatek.c: In function ‘ufs_mtk_system_suspend’:
> drivers/ufs/host/ufs-mediatek.c:1371:8: error: implicit declaration of function ‘ufshcd_system_suspend’; did you mean ‘ufs_mtk_system_suspend’? [-Werror=implicit-function-declaration]
> ret = ufshcd_system_suspend(dev);
> ^~~~~~~~~~~~~~~~~~~~~
> ufs_mtk_system_suspend
> drivers/ufs/host/ufs-mediatek.c: In function ‘ufs_mtk_system_resume’:
> drivers/ufs/host/ufs-mediatek.c:1386:9: error: implicit declaration of function ‘ufshcd_system_resume’; did you mean ‘ufs_mtk_system_resume’? [-Werror=implicit-function-declaration]
> return ufshcd_system_resume(dev);
> ^~~~~~~~~~~~~~~~~~~~
> ufs_mtk_system_resume
> cc1: some warnings being treated as errors
>
> [...]

Applied to 5.20/scsi-queue, thanks!

[1/1] scsi: ufs: ufs-mediatek: Fix build error and type unmatch
https://git.kernel.org/mkp/scsi/c/f54912b228a8

--
Martin K. Petersen Oracle Linux Engineering