Re: [PATCH 5/5] OPP: Remove custom OPP helper support

From: Dmitry Osipenko
Date: Mon Jun 27 2022 - 03:09:26 EST


27.06.2022 09:41, Viresh Kumar пишет:
> On 27-06-22, 09:10, Dmitry Osipenko wrote:
>> Okay, but Tegra 3d driver doesn't need config_regulators(), it needs
>> customized set_opp() to set clock rate for both 3d engines.
>
> What does that mean, you need to set two clocks ? There is separate
> support added for that already [1].
>

Yes, I missed that multi-clock OPP patch, thanks.

Seems _opp_compare_key() won't work properly for the multi-clocks since
Tegra doesn't have bandwidth nor level for the 3d OPPs. Why does it need
to check opp_table->clk_count == 1? Shouldn't it be opp_table->clk_count
> 0?