Re: [net-next 2/2] dt-bindings: net: adin1110: Add docs

From: Andrew Lunn
Date: Sun Jun 26 2022 - 06:06:23 EST


> +patternProperties:
> + "^phy@[0-1]$":
> + description: |
> + ADIN1100 PHY that is present on the same chip as the MAC.
> + type: object
> +
> + properties:
> + reg:
> + items:
> + maximum: 1
> +
> + allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: adi,adin1110
> + then:
> + properties:
> + compatible:
> + const: ethernet-phy-id0283.bc91
> + else:
> + properties:
> + compatible:
> + const: ethernet-phy-id0283.bca1
> +
> + required:
> + - compatible
> + - reg

Why is any of this needed? You register an MDIO bus and then use the
PHY at address 0 or 1. phylib should find the PHY and read its ID
register to load the driver. So i don't think there is anything useful
here.

Andrew