Re: [PATCH 1/6] ksmbd: use vfs_llseek instead of dereferencing NULL

From: Namjae Jeon
Date: Sat Jun 25 2022 - 00:10:37 EST


2022-06-25 1:56 GMT+09:00, Jason A. Donenfeld <Jason@xxxxxxxxx>:
> By not checking whether llseek is NULL, this might jump to NULL. Also,
> it doesn't check FMODE_LSEEK. Fix this by using vfs_llseek(), which
> always does the right thing.
>
> Fixes: f44158485826 ("cifsd: add file operations")
> Cc: stable@xxxxxxxxxxxxxxx
> Cc: linux-cifs@xxxxxxxxxxxxxxx
> Cc: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
> Cc: Steve French <stfrench@xxxxxxxxxxxxx>
> Cc: Ronnie Sahlberg <lsahlber@xxxxxxxxxx>
> Cc: Hyunchul Lee <hyc.lee@xxxxxxxxx>
> Cc: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>

Reviewed-by: Namjae Jeon <linkinjeon@xxxxxxxxxx>

Thanks!