Re: [PATCH] media: docs: Modify the section of User xattr

From: Bagas Sanjaya
Date: Fri Jun 24 2022 - 21:15:52 EST


On 6/24/22 08:46, Deming Wang wrote:
> Delete duplicate words of "the".
>

I think "Modify something" isn't clear subject, because reviewers
don't know at glance the logical change this patch is doing other
than actually reading the diff below.

For the patch message, what about "Remove duplicate the"?

In this case of trivial patch, it's OK to have the patch message
same as the subject, if the message can't be described more
concise but clearer.

> @@ -607,7 +607,7 @@ can be removed.
> User xattr
> ----------
>
> -The the "-o userxattr" mount option forces overlayfs to use the
> +The "-o userxattr" mount option forces overlayfs to use the
> "user.overlay." xattr namespace instead of "trusted.overlay.". This is
> useful for unprivileged mounting of overlayfs.
>

The diff looks OK.

Thanks.

--
An old man doll... just what I always wanted! - Clara