Re: [PATCH v2] rpmsg: fix possible refcount leak in rpmsg_register_device_override()

From: Krzysztof Kozlowski
Date: Fri Jun 24 2022 - 13:45:15 EST


On 24/06/2022 19:36, Mathieu Poirier wrote:
> On Fri, Jun 24, 2022 at 10:41:20AM +0800, Hangyu Hua wrote:
>> rpmsg_register_device_override need to call put_device to free vch when
>> driver_set_override fails.
>>
>> Fix this by adding a put_device() to the error path.
>>
>> Fixes: bb17d110cbf2 ("rpmsg: Fix calling device_lock() on non-initialized device")
>
> This is funny... Neither Bjorn nor I have reviewed this patch...

It was a fix for commit in Greg's tree and Greg's pick it up after a
week or something. I am not sure if that's actually funny that Greg has
to pick it up without review :(

Best regards,
Krzysztof