Re: [PATCH v4 3/3] Staging: rtl8192e: Cleaning up error handling

From: Dan Carpenter
Date: Fri Jun 24 2022 - 01:21:51 EST


On Thu, Jun 23, 2022 at 11:20:49PM +0200, Andy Shevchenko wrote:
> On Thu, Jun 23, 2022 at 10:44 PM Felix Schlepper <f3sch.git@xxxxxxxxxxx> wrote:
> >
> > Moved error handling to one common block.
> > This removes double checking if all txb->fragments[]
> > were initialized.
> > The original code worked fine, but this is cleaner.
>
> ...
>
> > +err_free:
> > + while (--i >= 0)
>
> while (i--)
>
> will suffice.
>

Either one is fine. You prefer this format. I prefer that other
format. I told Felix he could use either format without expressing any
bias and he chose my format. That means he loves me more.

regards,
dan carpenter