Re: [PATCH v4 3/3] Staging: rtl8192e: Cleaning up error handling

From: Andy Shevchenko
Date: Thu Jun 23 2022 - 17:21:41 EST


On Thu, Jun 23, 2022 at 10:44 PM Felix Schlepper <f3sch.git@xxxxxxxxxxx> wrote:
>
> Moved error handling to one common block.
> This removes double checking if all txb->fragments[]
> were initialized.
> The original code worked fine, but this is cleaner.

...

> +err_free:
> + while (--i >= 0)

while (i--)

will suffice.

> + dev_kfree_skb_any(txb->fragments[i]);
> + kfree(txb);
> +
> + return NULL;

--
With Best Regards,
Andy Shevchenko