[PATCH 04/16] mm/huge_memory: use helper touch_pud in huge_pud_set_accessed

From: Miaohe Lin
Date: Wed Jun 22 2022 - 13:06:39 EST


Use helper touch_pud to set pud accessed to simplify the code and improve
the readability. No functional change intended.

Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
---
mm/huge_memory.c | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index a26580da8011..a0c0e4bf9c1e 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -1281,21 +1281,15 @@ int copy_huge_pud(struct mm_struct *dst_mm, struct mm_struct *src_mm,

void huge_pud_set_accessed(struct vm_fault *vmf, pud_t orig_pud)
{
- pud_t entry;
- unsigned long haddr;
- bool write = vmf->flags & FAULT_FLAG_WRITE;
+ int flags = 0;

vmf->ptl = pud_lock(vmf->vma->vm_mm, vmf->pud);
if (unlikely(!pud_same(*vmf->pud, orig_pud)))
goto unlock;

- entry = pud_mkyoung(orig_pud);
- if (write)
- entry = pud_mkdirty(entry);
- haddr = vmf->address & HPAGE_PUD_MASK;
- if (pudp_set_access_flags(vmf->vma, haddr, vmf->pud, entry, write))
- update_mmu_cache_pud(vmf->vma, vmf->address, vmf->pud);
-
+ if (vmf->flags & FAULT_FLAG_WRITE)
+ flags = FOLL_WRITE;
+ touch_pud(vmf->vma, vmf->address, vmf->pud, flags);
unlock:
spin_unlock(vmf->ptl);
}
--
2.23.0