Re: [PATCH 1/3] ASoC: dt-bindings: Add bindings for WCD9335 DAIs

From: Krzysztof Kozlowski
Date: Wed Jun 22 2022 - 10:35:12 EST


On 22/06/2022 08:47, Yassine Oudjana wrote:
> From: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>
>
> Add bindings for the DAIs available in WCD9335 to avoid
> having to use unclear number indices in device trees.
>
> Signed-off-by: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>
> ---
> MAINTAINERS | 1 +
> include/dt-bindings/sound/qcom,wcd9335.h | 15 +++++++++++++++
> 2 files changed, 16 insertions(+)
> create mode 100644 include/dt-bindings/sound/qcom,wcd9335.h
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b774f21828f7..2bcc3cc129c5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16366,6 +16366,7 @@ M: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> M: Banajit Goswami <bgoswami@xxxxxxxxxxx>
> L: alsa-devel@xxxxxxxxxxxxxxxx (moderated for non-subscribers)
> S: Supported
> +F: include/dt-bindings/sound/qcom,wcd9335.h
> F: sound/soc/codecs/lpass-va-macro.c
> F: sound/soc/codecs/lpass-wsa-macro.*
> F: sound/soc/codecs/msm8916-wcd-analog.c
> diff --git a/include/dt-bindings/sound/qcom,wcd9335.h b/include/dt-bindings/sound/qcom,wcd9335.h
> new file mode 100644
> index 000000000000..709d33ca748d
> --- /dev/null
> +++ b/include/dt-bindings/sound/qcom,wcd9335.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +
> +#ifndef __DT_QCOM_WCD9335_H
> +#define __DT_QCOM_WCD9335_H

Header guard should match better path, so:

__DT_SOUND_QCOM_WCD9335_H

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof