[ammarfaizi2-block:kvalo/ath/pending 3/10] drivers/net/wireless/ath/ath9k/hif_usb.c:251:57: warning: suggest braces around empty body in an 'else' statement

From: kernel test robot
Date: Wed Jun 22 2022 - 09:11:26 EST


tree: https://github.com/ammarfaizi2/linux-block kvalo/ath/pending
head: ff1c40050ac3ca6a55ccc7970e37503e75465977
commit: d7fc76039b74ad37b7056d5607b05d7cb31a5404 [3/10] ath9k: htc: clean up statistics macros
config: xtensa-randconfig-r033-20220622 (https://download.01.org/0day-ci/archive/20220622/202206222110.WLZh7cQf-lkp@xxxxxxxxx/config)
compiler: xtensa-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/ammarfaizi2/linux-block/commit/d7fc76039b74ad37b7056d5607b05d7cb31a5404
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block kvalo/ath/pending
git checkout d7fc76039b74ad37b7056d5607b05d7cb31a5404
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash drivers/net/wireless/ath/ath9k/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

drivers/net/wireless/ath/ath9k/hif_usb.c: In function 'ath9k_skb_queue_complete':
>> drivers/net/wireless/ath/ath9k/hif_usb.c:251:57: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
251 | TX_STAT_INC(hif_dev, skb_failed);
| ^


vim +/else +251 drivers/net/wireless/ath/ath9k/hif_usb.c

233
234 static inline void ath9k_skb_queue_complete(struct hif_device_usb *hif_dev,
235 struct sk_buff_head *queue,
236 bool txok)
237 {
238 struct sk_buff *skb;
239
240 while ((skb = __skb_dequeue(queue)) != NULL) {
241 #ifdef CONFIG_ATH9K_HTC_DEBUGFS
242 int ln = skb->len;
243 #endif
244 ath9k_htc_txcompletion_cb(hif_dev->htc_handle,
245 skb, txok);
246 if (txok) {
247 TX_STAT_INC(hif_dev, skb_success);
248 TX_STAT_ADD(hif_dev, skb_success_bytes, ln);
249 }
250 else
> 251 TX_STAT_INC(hif_dev, skb_failed);
252 }
253 }
254

--
0-DAY CI Kernel Test Service
https://01.org/lkp