Re: [PATCH v1] staging: r8188eu: an incorrect return value made the function always return fail

From: Phillip Potter
Date: Wed Jun 22 2022 - 08:25:37 EST


On Mon, Jun 20, 2022 at 09:05:17AM -0500, Larry Finger wrote:
>
> The "for now" part is that Phillip plans to get rid of _FAIL and _SUCCESS,
> and replace the logic with a normal 1 for fail, etc.; however, this will be
> a major change that must be done carefully.
>
> In any case NACK for this patch.
>
> Larry
>
>
>

Hi all,

I would be happy to work on purging _FAIL and _SUCCESS from the driver
by all means - definitely a worthwhile goal. I know Pavel said he
might take a look too though - copying him in therefore to see if we can
coordinate an approach - happy to do as much or as little as desired.

Regards,
Phil