Re: [PATCH v3] arm/mm: Fix refcount leak bugs in cache

From: Krzysztof Kozlowski
Date: Wed Jun 22 2022 - 05:01:19 EST


On 19/06/2022 03:39, Liang He wrote:
> In feroceon_of_init() and tauros2_init(), of_find_matching_node()
> will return a node pointer with refcount incremented. We should
> use of_node_put() in fail path or when it is not used anymore.
>
> Signed-off-by: Liang He <windhl@xxxxxxx>
> ---
> changelog:
>
> v3: (1) merge arm/mm leak bugs (2) fix bugs intro-ed by v2
> v2: (1) use real name (2) normalize coding style
> v1: (1) fix leak bug
>

Before applying the patch please check it carefully. Previous evidence
[1][2] suggests that not it was not even compiled.



[1] https://lore.kernel.org/all/202206221602.odN70SHs-lkp@xxxxxxxxx/

[2]
https://lore.kernel.org/all/16f9a971.44e5.1817068ee3c.Coremail.windhl@xxxxxxx/


Best regards,
Krzysztof