Re: [PATCH v2] arm: mach-rockchip: (pm) Add missing of_node_put()

From: Krzysztof Kozlowski
Date: Wed Jun 22 2022 - 05:00:32 EST


On 16/06/2022 04:17, Liang He wrote:
> In rockchip_suspend_init(), of_find_matching_node_and_match() will
> return a node pointer with refcount incremented. We should use
> of_node_put() in fail path or when it is not used anymore.
>
> Signed-off-by: Liang He <windhl@xxxxxxx>
> ---
> changelog:
>
> v2: (1) use real name for Sob (2) use goto-label patch style
> v1: add of_node_put() for each return
>

Before applying the patch please check it carefully. Previous evidence
[1][2] suggests that not it was not even compiled.



[1] https://lore.kernel.org/all/202206221602.odN70SHs-lkp@xxxxxxxxx/

[2]
https://lore.kernel.org/all/16f9a971.44e5.1817068ee3c.Coremail.windhl@xxxxxxx/


Best regards,
Krzysztof