Re: [PATCH v1] arm64: dts: imx8mm-verdin: update CAN clock to 40MHz

[Marc Kleine-Budde]

On 22.06.2022 08:38:04, Andrejs Cainikovs wrote:
> > > >         can1: can@0 {
> > > >                 compatible = "microchip,mcp251xfd";
> > > > -               clocks = <&clk20m>;
> > > > +               clocks = <&clk40m>;
> > > >                 interrupts-extended = <&gpio1 6
> > > > IRQ_TYPE_EDGE_FALLING>;
> > 
> > You don't want to use an edge triggered interrupt with the mcp251xfd
> > chip. You will be losing interrupts, better use IRQ_TYPE_LEVEL_LOW.
> 
> This particular change is not about interrupts.

Sure, I just noticed it.

> But thanks for a hint, I'll make sure this is addressed.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature