Re: [Intel-wired-lan] [PATCH][next] iavf: Replace one-element array in struct virtchnl_iwarp_qvlist_info and iavf_qvlist_info

[Tony Nguyen]

On 6/17/2022 9:00 AM, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping (after more than a year after I sent this patch :O):
>
> Who can review and/or take this patch, please?

Hi Gustavo,

IIRC this could cause some issues with the expectations of the virtchnl 
structures [1] for compatibility. There was a direction that we were 
going to head to resolve this. Unfortunately, the person who, I believe, 
was going to make this change is out for a couple of weeks. I will ask 
around and see if I can get any updates on this work. Otherwise, I'll 
ask him when he returns.

Thanks,
Tony

[1] 
https://lore.kernel.org/intel-wired-lan/f2fe13346f1d44ee9047254a95914d00@xxxxxxxxx/

> Thanks
> --
> Gustavo
>
> On 5/26/21 01:04, Gustavo A. R. Silva wrote:
> > There is a regular need in the kernel to provide a way to declare 
> > having a
> > dynamically sized set of trailing elements in a structure. Kernel code
> > should always use “flexible array members”[1] for these cases. The older
> > style of one-element or zero-length arrays should no longer be used[2].
> >
> > Refactor the code according to the use of a flexible-array member in 
> > struct
> > virtchnl_iwarp_qvlist_info and iavf_qvlist_info instead of one-element 
> > array,
> > and use the flex_array_size() helper.
> >
> > [1] https://en.wikipedia.org/wiki/Flexible_array_member
> > [2] 
> > https://www.kernel.org/doc/html/v5.10/process/deprecated.html#zero-length-and-one-element-arrays 
> >
> >
> > Link: https://github.com/KSPP/linux/issues/79
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>