Re: [net-next: PATCH 03/12] net: dsa: switch to device_/fwnode_ APIs

From: Andy Shevchenko
Date: Tue Jun 21 2022 - 07:02:56 EST


On Tue, Jun 21, 2022 at 11:27:43AM +0200, Marcin Wojtas wrote:
> pon., 20 cze 2022 o 19:41 Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> napisał(a):
> > On Mon, Jun 20, 2022 at 05:02:16PM +0200, Marcin Wojtas wrote:

...

> > > struct device_node *dn;
> >
> > What prevents us from removing this?
>
> I left it to satisfy possible issues with backward compatibility - I
> migrated mv88e6xxx, other DSA drivers still rely on of_* and may use
> this field.

If it is so, it's a way to get into troubles of desynchronized dn and fwnode.

> > > + struct fwnode_handle *fwnode;

--
With Best Regards,
Andy Shevchenko