Re: [PATCH 46/49] regmap-irq: Refactor checks for status bulk read support

From: Andy Shevchenko
Date: Tue Jun 21 2022 - 05:45:58 EST


On Mon, Jun 20, 2022 at 10:11 PM Aidan MacDonald
<aidanmacdonald.0x0@xxxxxxxxx> wrote:
>
> There are several conditions that must be satisfied to support
> bulk read of status registers. Move the check into a function
> to avoid duplicating it in two places.

...

> - } else if (!map->use_single_read && map->reg_stride == 1 &&
> - data->irq_reg_stride == 1) {
> + } else if (regmap_irq_can_bulk_read_status(data)) {

>

While at it, you may drop this unneeded blank line.

> u8 *buf8 = data->status_reg_buf;
> u16 *buf16 = data->status_reg_buf;

--
With Best Regards,
Andy Shevchenko