Re: [PATCH v4 13/34] test_printf: Drop requirement that sprintf not write past nul

From: Kent Overstreet
Date: Tue Jun 21 2022 - 03:52:30 EST


On Tue, Jun 21, 2022 at 09:19:55AM +0200, Rasmus Villemoes wrote:
> On 20/06/2022 02.42, Kent Overstreet wrote:
> > The current test code checks that sprintf never writes past the
> > terminating nul. This is a rather strange requirement, completely
> > separate from writing past the end of the buffer, which of course we
> > can't do
>
> And which of course you don't check anymore. So any statement about "all
> tests passing after these patches" is not worth much.
>
> So NAK in this form, but perhaps if/when my year-old patch gets picked
> up (or you could include it in the series) we can talk about eliminating
> the check for past-nul-before-end-of-buffer writes.

I'm more than happy to pick up your patch, please send it to me.