Re: [PATCH v2] ipv4: ping: fix bind address validity check

From: Greg KH
Date: Mon Jun 20 2022 - 06:11:46 EST


On Fri, Jun 17, 2022 at 04:45:52PM -0700, Maciej Żenczykowski wrote:
> On Fri, Jun 17, 2022 at 4:30 AM <patchwork-bot+netdevbpf@xxxxxxxxxx> wrote:
> >
> > Hello:
> >
> > This patch was applied to netdev/net.git (master)
> > by David S. Miller <davem@xxxxxxxxxxxxx>:
> >
> > On Fri, 17 Jun 2022 10:54:35 +0200 you wrote:
> > > Commit 8ff978b8b222 ("ipv4/raw: support binding to nonlocal addresses")
> > > introduced a helper function to fold duplicated validity checks of bind
> > > addresses into inet_addr_valid_or_nonlocal(). However, this caused an
> > > unintended regression in ping_check_bind_addr(), which previously would
> > > reject binding to multicast and broadcast addresses, but now these are
> > > both incorrectly allowed as reported in [1].
> > >
> > > [...]
> >
> > Here is the summary with links:
> > - [v2] ipv4: ping: fix bind address validity check
> > https://git.kernel.org/netdev/net/c/b4a028c4d031
> >
> > You are awesome, thank you!
> > --
> > Deet-doot-dot, I am a bot.
> > https://korg.docs.kernel.org/patchwork/pwbot.html
>
> I believe this [
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=b4a028c4d031
> ] needs to end up in 5.17+ LTS (though I guess 5.17 is eol, so
> probably just 5.18)

5.17 is end-of-life, sorry.

And this needs to hit Linus's tree first.

thanks,

greg k-h