Re: [PATCH v3 07/18] dt-bindings: reset: npcm: add GCR syscon property

[Tomer Maimon]

Hi Krzysztof,

On Mon, 20 Jun 2022 at 11:22, Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 19/06/2022 17:12, Tomer Maimon wrote:
> > Describe syscon property that handles general control registers (GCR) in
> > Nuvoton BMC NPCM reset driver.
> >
> > Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx>
> > ---
> >  .../devicetree/bindings/reset/nuvoton,npcm750-reset.yaml     | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml b/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml
> > index fa5e4ea6400e..7ba3a6ff82ed 100644
> > --- a/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml
> > +++ b/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml
> > @@ -19,6 +19,9 @@ properties:
> >    '#reset-cells':
> >      const: 2
> >
> > +  nuvoton,sysgcr:
> > +    description: a phandle to access GCR registers.
>
> That's not valid. You miss here ref. My comment was to skip quotes and
> you removed entire ref.
Will add the ref next version.
>
> Best regards,
> Krzysztof

Best regards,

Tomer