Re: [PATCH v2] sh: Convert nommu io{re,un}map() to static inline functions

From: Christoph Hellwig
Date: Mon Jun 20 2022 - 03:06:15 EST


On Mon, Jun 20, 2022 at 09:01:43AM +0200, Geert Uytterhoeven wrote:
> Recently, nommu iounmap() was converted from a static inline function to
> a macro again, basically reverting commit 4580ba4ad2e6b8dd ("sh: Convert
> iounmap() macros to inline functions"). With -Werror, this leads to
> build failures like:

Stupid question: Is there any reason sh-nommu can't just use the
generic nommu ioremap from asm-generic/io.h?

Then again how long it takes to to fix any sh bugs I'm still wondering
if we shouldn't just drop sh entirely given how much of a drag it is
on everyone.