Re: [PATCH v8 05/11] iommu/vt-d: Add SVA domain support

[Baolu Lu]

On 2022/6/17 15:47, Tian, Kevin wrote:
> > From: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> > Sent: Tuesday, June 7, 2022 9:50 AM
> >
> > +
> > +static const struct iommu_domain_ops intel_svm_domain_ops = {
> > +	.set_dev_pasid		= intel_svm_attach_dev_pasid,
> > +	.block_dev_pasid	= intel_svm_detach_dev_pasid,
> > +	.free			= intel_svm_domain_free,
> > +};
> > +
>
> It's clearer to use set/block for intel callbacks.

Yes. That reads clearer.

--
Best regards,
baolu