Re: [PATCH 2/3] regmap: Make regmap_noinc_read() return -ENOTSUPP if map->read isn't set

[Marek Vasut]

On 6/16/22 09:34, Javier Martinez Canillas wrote:
> Before adding support to define bulk read/write callbacks in regmap_config
> by the commit d77e74561368 ("regmap: Add bulk read/write callbacks into
> regmap_config"), the regmap_noinc_read() function returned an errno early
> a map->bus->read callback wasn't set.
>
> But that commit dropped the check and now a call to _regmap_raw_read() is
> attempted even when bulk read operations are not supported. That function
> checks for map->read anyways but there's no point to continue if the read
> can't succeed.
>
> Also is a fragile assumption to make so is better to make it fail earlier.
>
> Fixes: d77e74561368 ("regmap: Add bulk read/write callbacks into regmap_config")
> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

Reviewed-by: Marek Vasut <marex@xxxxxxx>