Re: [PATCH v8 5/5] arm64: dts: qcom: sc7180: Add kingoftown dts files

From: Doug Anderson
Date: Fri Jun 17 2022 - 20:17:05 EST


Hi,

On Fri, Jun 17, 2022 at 4:40 PM Joseph S. Barrera III
<joebar@xxxxxxxxxxxx> wrote:
>
> Kingoftown is a trogdor-based board. These dts files are unchanged copies
> from the downstream Chrome OS 5.4 kernel.
>
> Signed-off-by: Joseph S. Barrera III <joebar@xxxxxxxxxxxx>
> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> ---
>
> (no changes since v7)
>
> Changes in v7:
> - Incorporated changes from Stephen's "Simplify!" series.
>
> Changes in v4:
> - Fixed description (no downstream bits removed).
> - Added missing version history.
>
> Changes in v2:
> - First inclusion in series.
>
> arch/arm64/boot/dts/qcom/Makefile | 2 +
> .../dts/qcom/sc7180-trogdor-kingoftown-r0.dts | 44 ++++
> .../dts/qcom/sc7180-trogdor-kingoftown-r1.dts | 17 ++
> .../dts/qcom/sc7180-trogdor-kingoftown.dtsi | 220 ++++++++++++++++++
> 4 files changed, 283 insertions(+)

I'm not doing a detailed review, but many of the same comments from
the pazquel review apply here as well.

-Doug