Re: [PATCH v2 05/15] dt-bindings: backlight: Add Mediatek MT6370 backlight

From: Krzysztof Kozlowski
Date: Fri Jun 17 2022 - 19:15:33 EST


On 17/06/2022 03:35, ChiaEn Wu wrote:
> + - 3: 6
>>
>> Nope, I said last time:
>> "In any case you cannot have values mapping"
>>
>> Please use proper real world value, not some register bits. The property
>> name also needs fixing.
>
> I so apologized for misunderstanding your meaning...
> I try to modify it like below.
> --------
> mediatek,bled-pwm-hys-input-threshold-steps:
> $ref: /schemas/types.yaml#/definitions/uint8
> enum: [1, 4, 16, 64]
> description: |
> The selection of the upper and lower bounds threshold of backlight
> PWM resolution. If we choose selection 64, the variation of PWM
> resolution needs over 64 steps.
> --------
> If these changes meet your expectations, I will try to modify
> "bled-ovp-microvolt" and "bled-ocp-microamp" in the same way.
> Thank you so much.
>

This looks good. Thank you.


Best regards,
Krzysztof