Re: [PATCH 5/5] blk-mq: Drop 'reserved' member of busy_tag_iter_fn

[Bart Van Assche]

On 6/17/22 09:42, John Garry wrote:
> On 17/06/2022 17:33, Bart Van Assche wrote:
> > On 6/17/22 03:55, John Garry wrote:
> > > @@ -276,7 +275,7 @@ static bool bt_iter(struct sbitmap *bitmap, 
> > > unsigned int bitnr, void *data)
> > >       else
> > >           tags = hctx->tags;
> > > -    if (!reserved)
> > > +    if (!iter_data->reserved)
> > >           bitnr += tags->nr_reserved_tags;
> > >       /*
> > >        * We can hit rq == NULL here, because the tagging functions
> >
> > Is the above change really necessary?
>
> It's not totally necessary. Since local variable 'reserved' would now 
> only be used once I thought it was better to get rid of it.
>
> I can keep it if you really think that is better.

I'd prefer that these changes are either left out or that these are 
moved into a separate patch. I think that will make this patch series 
easier to review.

Thanks,

Bart.