Re: [PATCH 08/31] cpufreq: tegra20: Migrate to dev_pm_opp_set_config()

From: Dmitry Osipenko
Date: Fri Jun 17 2022 - 08:09:43 EST


On 6/7/22 11:43, Viresh Kumar wrote:
> On 30-05-22, 13:22, Viresh Kumar wrote:
>> On 29-05-22, 19:59, Dmitry Osipenko wrote:
>>>> Please keep the PTR_ERR_OR_ZERO.
>>
>> Ahh, sorry about that. Fixed.
>>
>>>> tegra20-cpufreq tegra20-cpufreq: failed to set OPP config: -1042688000
>>>
>>> With that fixed, now there is another error:
>>>
>>> [ 1.761945] cpu cpu0: _of_add_opp_table_v2: no supported OPPs
>>> [ 1.761960] cpu cpu0: OPP table can't be empty
>>
>> So we failed to find any OPPs which work with the hardware version of
>> updated with dev_pm_opp_set_config(). I tried to follow the path and
>> see if there is something wrong here. Failed to find that :(
>>
>>> I see this on Tegra30, but not on Tegra20. Apparently OPP table
>>> refcounting is broken on Tegra30 by this patchset. To make it clear,
>>> there are no error without these OPP patches applied. I may take a
>>> closer look if will be needed, just ping me.
>>
>> Yes, it would be very helpful as I don't have the necessary hardware.
>
> Hey, any updates on this ? I am looking to resend the series soon, would be nice
> to fix this before that.
>

I'll take a look over this weekend. Sorry for the delay.

--
Best regards,
Dmitry