[PATCH -next] drivers/tty/serial: Add missing clk_disable_unprepare()

From: Guo Mengqi
Date: Thu Jun 16 2022 - 23:04:32 EST


Add missing clk_disable_unprepare() when get clk rate fails.

Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Signed-off-by: Guo Mengqi <guomengqi3@xxxxxxxxxx>
---
drivers/tty/serial/8250/8250_bcm2835aux.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_bcm2835aux.c b/drivers/tty/serial/8250/8250_bcm2835aux.c
index 2a1226a78a0c..21939bb44613 100644
--- a/drivers/tty/serial/8250/8250_bcm2835aux.c
+++ b/drivers/tty/serial/8250/8250_bcm2835aux.c
@@ -166,8 +166,10 @@ static int bcm2835aux_serial_probe(struct platform_device *pdev)
uartclk = clk_get_rate(data->clk);
if (!uartclk) {
ret = device_property_read_u32(&pdev->dev, "clock-frequency", &uartclk);
- if (ret)
- return dev_err_probe(&pdev->dev, ret, "could not get clk rate\n");
+ if (ret) {
+ dev_err_probe(&pdev->dev, ret, "could not get clk rate\n");
+ goto dis_clk;
+ }
}

/* the HW-clock divider for bcm2835aux is 8,
--
2.17.1