Re: [PATCH] drivers/char/agp: Remove unnecessary variable assignment in agp_generic_create_gatt_table()

From: Shuah Khan
Date: Thu Jun 16 2022 - 15:51:36 EST


On 6/16/22 12:19 PM, Gautam Menghani wrote:
Remove unnecessary variable assignment in the function
agp_generic_create_gatt_table(). This fixes the clang scan warnings:

warning: Value stored to 'page_order' is never read [deadcode.DeadStores]
page_order = num_entries = 0;

warning: Although the value stored to 'num_entries' is used in the
enclosing expression, the value is never actually read from 'num_entries'
[deadcode.DeadStores]

Signed-off-by: Gautam Menghani <gautammenghani201@xxxxxxxxx>
---
drivers/char/agp/generic.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/char/agp/generic.c b/drivers/char/agp/generic.c
index 3ffbb1c80c5c..046ef61132f6 100644
--- a/drivers/char/agp/generic.c
+++ b/drivers/char/agp/generic.c
@@ -864,7 +864,6 @@ int agp_generic_create_gatt_table(struct agp_bridge_data *bridge)
table = NULL;
i = bridge->aperture_size_idx;
temp = bridge->current_size;
- page_order = num_entries = 0;

It would be safe to initialize page_order and num_entries when
they are declared a few lines above.

if (bridge->driver->size_type != FIXED_APER_SIZE) {
do {


thanks,
-- Shuah