Re: [PATCH] arm64/hugetlb: Implement arm64 specific hugetlb_mask_last_hp

From: kernel test robot
Date: Thu Jun 16 2022 - 06:51:08 EST


Hi Baolin,

I love your patch! Yet something to improve:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on linus/master v5.19-rc2 next-20220616]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Baolin-Wang/arm64-hugetlb-Implement-arm64-specific-hugetlb_mask_last_hp/20220616-113640
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: arm64-buildonly-randconfig-r001-20220616 (https://download.01.org/0day-ci/archive/20220616/202206161848.w1bWqr7O-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/f1309dfbc2b70ec5dd72ac38e95a49b7be42b9b6
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Baolin-Wang/arm64-hugetlb-Implement-arm64-specific-hugetlb_mask_last_hp/20220616-113640
git checkout f1309dfbc2b70ec5dd72ac38e95a49b7be42b9b6
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/mm/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

arch/arm64/mm/hugetlbpage.c:371:15: warning: no previous prototype for 'hugetlb_mask_last_hp' [-Wmissing-prototypes]
371 | unsigned long hugetlb_mask_last_hp(struct hstate *h)
| ^~~~~~~~~~~~~~~~~~~~
arch/arm64/mm/hugetlbpage.c: In function 'hugetlb_mask_last_hp':
>> arch/arm64/mm/hugetlbpage.c:380:9: error: duplicate case value
380 | case PMD_SIZE:
| ^~~~
arch/arm64/mm/hugetlbpage.c:376:9: note: previously used here
376 | case PUD_SIZE:
| ^~~~


vim +380 arch/arm64/mm/hugetlbpage.c

370
371 unsigned long hugetlb_mask_last_hp(struct hstate *h)
372 {
373 unsigned long hp_size = huge_page_size(h);
374
375 switch (hp_size) {
376 case PUD_SIZE:
377 return PGDIR_SIZE - PUD_SIZE;
378 case CONT_PMD_SIZE:
379 return PUD_SIZE - CONT_PMD_SIZE;
> 380 case PMD_SIZE:
381 return PUD_SIZE - PMD_SIZE;
382 case CONT_PTE_SIZE:
383 return PMD_SIZE - CONT_PTE_SIZE;
384 default:
385 break;
386 }
387
388 return ~0UL;
389 }
390

--
0-DAY CI Kernel Test Service
https://01.org/lkp