Re: [PATCH 1/2] dt-bindings: mfd: mt6397: Add compatibles for MT6331 RTC and keys

[AngeloGioacchino Del Regno]

Il 15/06/22 23:48, Lee Jones ha scritto:
> On Fri, 20 May 2022, AngeloGioacchino Del Regno wrote:
>
> > MT6331 is a multifunction device, providing RTC, keys and more: add
>
> No such thing as an MFD.  What does the data-sheet call it?

Datasheets for this chip, or the other (6332) are not public ... and I have no
access to any: whatever you see here is done with an accurate reading of downstream
drivers and a lot of debugging and research.

Anyway, MT6331 is a PMIC, MT6332 is also a PMIC (in this case, a companion pmic).

> What "more"?

More is voltage regulators, display backlight PWM, LED PWM, some GPIOs, battery
charging, fuel gauge... and I think nothing else.

Anyway, okay I will list things out in the commit description.

> > the necessary compatibles to start implementing the basics.
> >
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/mfd/mt6397.txt | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt
> > index d59063503b0d..2a9533c47365 100644
> > --- a/Documentation/devicetree/bindings/mfd/mt6397.txt
> > +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt
> > @@ -30,6 +30,7 @@ Optional subnodes:
> >   - rtc
> >   	Required properties: Should be one of follows
> >   		- compatible: "mediatek,mt6323-rtc"
> > +		- compatible: "mediatek,mt6331-rtc"
> >   		- compatible: "mediatek,mt6358-rtc"
> >   		- compatible: "mediatek,mt6397-rtc"
> >   	For details, see ../rtc/rtc-mt6397.txt
> > @@ -55,6 +56,7 @@ Optional subnodes:
> >   - keys
> >   	Required properties:
> >   		- compatible: "mediatek,mt6397-keys" or "mediatek,mt6323-keys"
> > +			      or "mediatek,mt6331-keys"
>
> Please place these in a vertical list.

Will do!

Regards,
Angelo