Re:Re: [PATCH v2] drivers: clk: (clk-nomadik) Add missing of_node_put()

From: Liang He
Date: Thu Jun 16 2022 - 04:27:03 EST




At 2022-06-16 14:02:23, "Stephen Boyd" <sboyd@xxxxxxxxxx> wrote:
>Same subject line comment applies here. Look at previous patches to the
>file.

Sorry, what do you mean same subject line comment?

I add a [PATCH v2] tag when I use 'git format-patch -v 2'.

You mean the two commit has same subject content?

Sorry, I am a beginner to submit patch commit.

>
>Quoting Liang He (2022-06-15 20:24:48)
>> diff --git a/drivers/clk/clk-nomadik.c b/drivers/clk/clk-nomadik.c
>> index bad2677e11ae..48d5772b36a5 100644
>> --- a/drivers/clk/clk-nomadik.c
>> +++ b/drivers/clk/clk-nomadik.c
>> @@ -99,7 +99,7 @@ static void __init nomadik_src_init(void)
>> if (!src_base) {
>> pr_err("%s: must have src parent node with REGS (%pOFn)\n",
>> __func__, np);
>> - return;
>> + goto out_put;
>> }
>>
>> /* Set all timers to use the 2.4 MHz TIMCLK */
>> @@ -132,6 +132,9 @@ static void __init nomadik_src_init(void)
>> }
>> writel(val, src_base + SRC_XTALCR);
>> register_reboot_notifier(&nomadik_clk_reboot_notifier);
>> +
>> +output:
>> + of_node_put(np);
>
>tabbed incorrectly?

Sorry for this incorrct tab setting.