Re: [PATCH V3 2/2] mm/mmap: Drop generic protection_map[] array

From: hch@xxxxxxxxxxxxx
Date: Thu Jun 16 2022 - 02:10:37 EST


On Thu, Jun 16, 2022 at 05:27:15AM +0000, Christophe Leroy wrote:
>
>
> Le 16/06/2022 à 06:09, Anshuman Khandual a écrit :
> > Move the protection_array[] array inside the arch for those platforms which
>
> s/protection_array/protection_map
>
> > do not enable ARCH_HAS_VM_GET_PAGE_PROT. Afterwards __SXXX/__PXX macros can
> > be dropped completely which are now redundant.
>
> I see some protection_map[] are __ro_after_init, some not.
>
> I'm sure several of them could be const as they are never modified.

Yes, most should be const as they are never modified. A few have init
time modifications and can be __ro_after_init. If we actually have
any that are modified later on that is a bug that we need to look into
with the respective arch maintainers.