Re: [net-next PATCH] net: ethernet: stmicro: stmmac: permit MTU change with interface up

From: Jakub Kicinski
Date: Wed Jun 15 2022 - 22:55:13 EST


On Wed, 15 Jun 2022 00:41:41 +0200 Christian 'Ansuel' Marangi wrote:
> + if (netif_running(dev)) {
> + netdev_dbg(priv->dev, "restarting interface to change its MTU\n");
> + stmmac_release(dev);
> +
> + stmmac_open(dev);
> + stmmac_set_filter(priv, priv->hw, dev);

What if stmmac_open() fails because the memory is low or is fragmented?

You'd need to invest more effort into this change and try to allocate
all the resources before shutting the device down.