RE: [PATCH 3/3] include: ufs: re-arrange addresses in increasing order

From: Chanho Park
Date: Wed Jun 15 2022 - 20:11:24 EST


> Subject: [PATCH 3/3] include: ufs: re-arrange addresses in increasing
> order
>
> Rearrange all the unipro and mphy addresses in their increasing order.
>
> Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> ---
> include/ufs/unipro.h | 102 +++++++++++++++++++++----------------------
> 1 file changed, 51 insertions(+), 51 deletions(-)
>
> diff --git a/include/ufs/unipro.h b/include/ufs/unipro.h index
> ade92e8d3676..4cbfe9272787 100644
> --- a/include/ufs/unipro.h
> +++ b/include/ufs/unipro.h
> @@ -38,6 +38,18 @@
> /*
> * M-RX Configuration Attributes
> */
> +#define RX_HS_G1_SYNC_LENGTH_CAP 0x008B
> +#define RX_HS_G1_PREP_LENGTH_CAP 0x008C
> +#define RX_MIN_ACTIVATETIME_CAPABILITY 0x008F
> +#define RX_HIBERN8TIME_CAPABILITY 0x0092
> +#define RX_HS_G2_SYNC_LENGTH_CAP 0x0094
> +#define RX_HS_G3_SYNC_LENGTH_CAP 0x0095
> +#define RX_HS_G2_PREP_LENGTH_CAP 0x0096
> +#define RX_HS_G3_PREP_LENGTH_CAP 0x0097
> +#define RX_ADV_GRANULARITY_CAP 0x0098
> +#define RX_HIBERN8TIME_CAP 0x0092
This should be removed.

Otherwise, looks good to me.

Reviewed-by: Chanho Park <chanho61.park@xxxxxxxxxxx>

Best Regards,
Chanho Park