Re: [PATCH v2 2/4] clk: qcom: clk-rcg2: Make sure to not write d=0 to the NMD register

From: Stephen Boyd
Date: Wed Jun 15 2022 - 15:41:38 EST


Quoting Nikita Travkin (2022-06-12 07:59:53)
> Sometimes calculation of d value may result in 0 because of the
> rounding after integer division. This causes the following error:
>
> [ 113.969689] camss_gp1_clk_src: rcg didn't update its configuration.
> [ 113.969754] WARNING: CPU: 3 PID: 35 at drivers/clk/qcom/clk-rcg2.c:122 update_config+0xc8/0xdc
>
> Make sure that D value is never zero.
>
> Fixes: 7f891faf596e ("clk: qcom: clk-rcg2: Add support for duty-cycle for RCG")
> Signed-off-by: Nikita Travkin <nikita@xxxxxxx>
>
> ---

Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxx>